JosephFerano/flan
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Folding a frame is a display operation when there is nothing to ask

Browse Source
This commit is contained in:
Joseph Ferano 2026-09-12 14:54:53 +07:00
parent 28fb034beb
commit c598169155
2 changed files with 24 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
emacs/flan-cnr.el
View File

@ -324,7 +324,13 @@ list already says it."
;; Fetched on first open and then kept: a frame's locals cannot change ;; Fetched on first open and then kept: a frame's locals cannot change
;; while the program is stopped, and re-asking on every fold would put a ;; while the program is stopped, and re-asking on every fold would put a
;; round trip behind a keystroke that looks like pure redrawing. ;; round trip behind a keystroke that looks like pure redrawing.
(when (memq i flan-cnr--open) ;; Only when there is something to ask. The fixture tests render this
;; buffer from a literal state with no socket behind it and no `flan-dev'
;; loaded, and folding a frame must stay a display operation there — the
;; renderer already draws a reason for a frame whose locals are nil, which
;; is the same degradation every other section of this buffer uses.
(when (and (memq i flan-cnr--open)
(functionp flan-cnr-request-function))
(let ((fr (nth i (plist-get flan-cnr--state :stack)))) (let ((fr (nth i (plist-get flan-cnr--state :stack))))
(when (and fr (not (plist-get fr :fetched))) (when (and fr (not (plist-get fr :fetched)))
(let ((answer (flan-cnr-locals i))) (let ((answer (flan-cnr-locals i)))

21
emacs/test-flan-cider.el
View File

@ -409,8 +409,12 @@
(goto-char (point-min)) (goto-char (point-min))
(search-forward " 1: > sim/step") (search-forward " 1: > sim/step")
(flan-cnr-toggle-frame) (flan-cnr-toggle-frame)
(test-flan--check "a frame with no locals refuses, naming DWARF" ;; DWARF stopped being the reason when the shadow stack landed: a frame
(string-match-p "not available.*DWARF" (buffer-string))) ;; with nothing nameable is one whose slots the compiler invented, or whose
;; bindings had not run.
(test-flan--check "a frame with no locals refuses, with a reason"
(string-match-p "not available.*no named locals"
(buffer-string)))
(goto-char (point-min)) (goto-char (point-min))
(search-forward " 0: v sim/settle") (search-forward " 0: v sim/settle")
(flan-cnr-toggle-frame) (flan-cnr-toggle-frame)
@ -472,7 +476,11 @@
;; The `layout' op, from this side: the condition's own name goes out as ;; The `layout' op, from this side: the condition's own name goes out as
;; `:type' and comes back as fields with no values. Two requests are made for ;; `:type' and comes back as fields with no values. Two requests are made for
;; one `C-c C-b' — `break' then `layout' — so the stub records both. ;; one `C-c C-b' — `break', `layout', then `backtrace' — so the stub records
;; all three. The assertions below look the `layout' request up by op rather
;; than by position: this list grew once already when `backtrace' landed, and a
;; positional assertion breaks every time the buffer learns to ask something
;; new, which is not what it is testing.
(let ((asked nil)) (let ((asked nil))
(let ((flan-cnr-request-function (let ((flan-cnr-request-function
(lambda (form) (lambda (form)
@ -487,7 +495,12 @@
(test-flan--check "the condition's name is what `layout' is asked for" (test-flan--check "the condition's name is what `layout' is asked for"
(equal (plist-get (car (last asked)) :op) "break")) (equal (plist-get (car (last asked)) :op) "break"))
(test-flan--check "and it is sent back verbatim, qualified as it came" (test-flan--check "and it is sent back verbatim, qualified as it came"
(equal (plist-get (car asked) :type) "sim/Missing")) (equal (plist-get
(seq-find (lambda (f)
(equal (plist-get f :op) "layout"))
asked)
:type)
"sim/Missing"))
(test-flan--check "the fields are drawn, named and typed" (test-flan--check "the fields are drawn, named and typed"
(string-match-p ":path *string" text)) (string-match-p ":path *string" text))
;; Shape and contents are two different questions, and only the first is ;; Shape and contents are two different questions, and only the first is