Joseph Ferano
d6fc15474b
The author: "I think I prefer length over len, because then I'll use len as the variable name". One arm in check.ml, one row in the table beside it, and every (len x) in lib, test, examples, vendor, spike, docs, web, emacs, plan.org and NEXT.md rewritten. Shadowing and builtin/ had already taken most of the sting out: a (defn len ...) was legal and won in its own file, and builtin/len reached past it. What was left is that len was still a builtin — the defn earned a warning, and a wrapper had to say builtin/ at every inner call. Now there is nothing under the short name: len is an ordinary identifier in every position, which is what (let [len (length xs)] ...) wants. length takes over as shadowing's worked example rather than the feature losing one. shadow-builtin.flan, builtin-qualified.flan, pkgs/shadowed and the builtin/ rows in test_flan move to it and go on testing shadowing. A call to a len nothing defines is answered where an unknown function is, after every table and after the shadowing guard, so a program with its own len never reaches it. The sentence is said rather than guessed at — len and length are three edits apart and the did-you-mean's net is one — and the call is written back out through spell_arg, as-slice's spelling lifted out of it and now shared, so what is printed compiles. sand.flan:33 still calls the old name and is the author's to change; until it does, test_acceptance and test_session abort there. Both were run green against a copy with that one line changed. FIX.org says so.
46 lines
2.1 KiB
Plaintext
46 lines
2.1 KiB
Plaintext
;;;; A defn named after a builtin, and what the name means afterwards.
|
|
;;;;
|
|
;;;; "Allow shadowing but warn": this file's (defn get ...) is legal, it wins
|
|
;;;; at every call site in this file, and the compiler says so once at the
|
|
;;;; definition — the warning is on stderr and the exit status does not move.
|
|
;;;;
|
|
;;;; Five lines printed, and between them the whole rule. In order:
|
|
;;;;
|
|
;;;; - 7: (get p) is one argument, which the builtin get does not take. It
|
|
;;;; compiles, and it prints the field, because the name resolves to the
|
|
;;;; definition below and the builtin is not consulted about its arity.
|
|
;;;; - 4: (shadowed/field m) reaches into the imported package, whose body
|
|
;;;; calls the builtin get on a dyn map. The shadow does not follow it
|
|
;;;; there: a package's calls mean what they meant when it was written.
|
|
;;;; - 99: an operator is a builtin like any other and shadows like one.
|
|
;;;; - 999: this file's own length, which is what length means in this file.
|
|
;;;; - 4 again, and it is the one that needed the work: the package's global
|
|
;;;; initialiser (defonce size i32 (length "abcd")) is checked with no
|
|
;;;; enclosing function at all, so there is no qualified name on it to say
|
|
;;;; it belongs to a package. The file it was written in says so instead.
|
|
|
|
(import shadowed "pkgs/shadowed")
|
|
|
|
(defstruct P [x i32])
|
|
|
|
(defn get [p P] i32 (.x p))
|
|
|
|
;;; An operator is a builtin like any other, and shadows like any other: (+ 1
|
|
;;; 2) below is this definition and answers 99. Nothing else in the program
|
|
;;; adds anything, and the prelude's own additions are untouched — the
|
|
;;; prelude is a different file.
|
|
(defn + [a i32 b i32] i32 99)
|
|
|
|
;;; And a builtin the imported package uses in a *global initialiser*, which
|
|
;;; is the one place there is no enclosing function to carry a package's
|
|
;;; qualified name. The package's (defonce size i32 (length "abcd")) is 4; this
|
|
;;; definition answers 999 and is reached only here.
|
|
(defn length [s string] i32 999)
|
|
|
|
(defn main [] ()
|
|
(println (get (P {.x 7})))
|
|
(println (shadowed/field {:a 1 :b 4}))
|
|
(println (+ 1 2))
|
|
(println (length "abcd"))
|
|
(println (shadowed/stored-size)))
|