Joseph Ferano
38a570bc7a
The bug review found: [start_on] claimed [started] at the top and every failure exit left it claimed. Under [flan dev] the constructor is the first caller and reports to nobody, so a path nothing could bind disarmed the program's own (agent/start ...) as well — it answered 0 with no socket, no listener and no hooks, where before this lane the explicit form answered -1. Success reported for nothing at all is worse than the error it replaced. So every way out that is not a listening socket unwinds: the fd is closed, a file the bind managed to make is unlinked, and [started] goes back to 0 so a later start is a real attempt. Pinned by running the zero-argument fixture with FLAN_AGENT_SOCKET pointing nowhere — constructor fails silently, main's own call then fails loudly, "cannot listen" and exit 1. Two arguments to (agent/start) are refused, which nothing held: the macro's [& args] cannot say "one at most", so what says it is the expansion splicing every argument into a function that declares one. The message names agent/start-at and carries the expanded-from note, and that is what the acceptance row asserts. And the reply a delivery gets when there is no agent in the process, which nothing held either. dev-noagent.flan parks, so it was never this case; dev-noagent-running.flan keeps running, and the answer is a refusal naming the socket that could not be reached — not install_note's "queued", which would promise a poll with nothing to drain. Which leaves that note unreachable in all three shapes rather than merely unpinned, worked through in FIX.org. FIX.org also now says what an exported FLAN_AGENT_SOCKET would do: start_on unlinks before it binds, so an agent-linked program started in that environment takes the path away from whoever bound it first.
15 lines
646 B
Plaintext
15 lines
646 B
Plaintext
;;;; (agent/start) takes no argument or one, and two is neither.
|
|
;;;;
|
|
;;;; The optional argument is a macro over two functions, and a macro with a
|
|
;;;; [& args] tail will take anything — so the refusal has to come from
|
|
;;;; somewhere. It comes from the expansion: every argument is spliced into
|
|
;;;; [start-at], which declares one, and the checker refuses the call it was
|
|
;;;; actually given. Dropping the extra argument instead would compile this
|
|
;;;; file and listen on the first path, which is the silent version of the
|
|
;;;; same mistake.
|
|
(import agent "vendor:agent")
|
|
|
|
(defn main [] i32
|
|
(agent/start "/tmp/one.sock" "/tmp/two.sock")
|
|
0)
|