Joseph Ferano
38a570bc7a
The bug review found: [start_on] claimed [started] at the top and every failure exit left it claimed. Under [flan dev] the constructor is the first caller and reports to nobody, so a path nothing could bind disarmed the program's own (agent/start ...) as well — it answered 0 with no socket, no listener and no hooks, where before this lane the explicit form answered -1. Success reported for nothing at all is worse than the error it replaced. So every way out that is not a listening socket unwinds: the fd is closed, a file the bind managed to make is unlinked, and [started] goes back to 0 so a later start is a real attempt. Pinned by running the zero-argument fixture with FLAN_AGENT_SOCKET pointing nowhere — constructor fails silently, main's own call then fails loudly, "cannot listen" and exit 1. Two arguments to (agent/start) are refused, which nothing held: the macro's [& args] cannot say "one at most", so what says it is the expansion splicing every argument into a function that declares one. The message names agent/start-at and carries the expanded-from note, and that is what the acceptance row asserts. And the reply a delivery gets when there is no agent in the process, which nothing held either. dev-noagent.flan parks, so it was never this case; dev-noagent-running.flan keeps running, and the answer is a refusal naming the socket that could not be reached — not install_note's "queued", which would promise a poll with nothing to drain. Which leaves that note unreachable in all three shapes rather than merely unpinned, worked through in FIX.org. FIX.org also now says what an exported FLAN_AGENT_SOCKET would do: start_on unlinks before it binds, so an agent-linked program started in that environment takes the path away from whoever bound it first.
27 lines
1.3 KiB
Plaintext
27 lines
1.3 KiB
Plaintext
;;;; A program that has not been told about the agent and is still running.
|
|
;;;;
|
|
;;;; dev-noagent.flan is the other half of this pair and stops short of it: its
|
|
;;;; main returns, so a moment later it is parked, and a redefinition sent to a
|
|
;;;; parked program is answered by the parking path. This one keeps running,
|
|
;;;; which is the state nothing had pinned: there is no agent in the process to
|
|
;;;; hand a module to and no socket to fall back on, so the daemon refuses the
|
|
;;;; delivery and says which socket it could not reach.
|
|
;;;;
|
|
;;;; That is the honest answer for it. The sentence [install_note] keeps for a
|
|
;;;; running program with no socket — queued, installs at its next
|
|
;;;; (agent/poll) — was true of a program that *links* the agent and has not
|
|
;;;; reached its (agent/start ...) yet, because there the ring is reachable
|
|
;;;; in-process while the socket is not yet bound. The package's constructor
|
|
;;;; binds before main now, so that window is gone; see FIX.org.
|
|
;;;;
|
|
;;;; So: no (import agent ...) anywhere, and a loop that outlasts the test.
|
|
(defn step [] i64 7)
|
|
|
|
(defn main [] i32
|
|
(print (step)) (println "")
|
|
;; Long enough that the session ends before the program does; short enough
|
|
;; that a daemon killed the hard way leaves nothing running for minutes.
|
|
(dotimes [i 3000]
|
|
(sleep-seconds 0.01))
|
|
0)
|