Joseph Ferano
a983a46ea5
The leak review found: an importer's (defn len ...) reached inside an imported package's (defvar sz i32 (len "abcd")) and made it 999. A global initialiser is checked with no enclosing function, so the qualified name the first cut asked about was not there to ask. The file the definition was written in is what the shadow follows now, which is what FIX.org had already named as the fix if it ever mattered. It mattered. builtin_set beside builtin_names: the guard is the first arm of the dispatch and ran a linear walk of eighty-odd strings at every named call. The list stays for the did-you-mean, whose order is its order. Pinned: a shadowed operator warns and lowers to a Call, and a call carrying another file's name reaches the builtin. The corpus program grew both cases and the package grew the initialiser that demonstrated the leak. And the int/float section's sentence about "the arity precedent, where the builtin wins" now says that the precedent was deleted the same day, since this lane is what deleted it.
46 lines
2.1 KiB
Plaintext
46 lines
2.1 KiB
Plaintext
;;;; A defn named after a builtin, and what the name means afterwards.
|
|
;;;;
|
|
;;;; "Allow shadowing but warn": this file's (defn get ...) is legal, it wins
|
|
;;;; at every call site in this file, and the compiler says so once at the
|
|
;;;; definition — the warning is on stderr and the exit status does not move.
|
|
;;;;
|
|
;;;; Five lines printed, and between them the whole rule. In order:
|
|
;;;;
|
|
;;;; - 7: (get p) is one argument, which the builtin get does not take. It
|
|
;;;; compiles, and it prints the field, because the name resolves to the
|
|
;;;; definition below and the builtin is not consulted about its arity.
|
|
;;;; - 4: (shadowed/field m) reaches into the imported package, whose body
|
|
;;;; calls the builtin get on a dyn map. The shadow does not follow it
|
|
;;;; there: a package's calls mean what they meant when it was written.
|
|
;;;; - 99: an operator is a builtin like any other and shadows like one.
|
|
;;;; - 999: this file's own len, which is what len means in this file.
|
|
;;;; - 4 again, and it is the one that needed the work: the package's global
|
|
;;;; initialiser (defvar size i32 (len "abcd")) is checked with no
|
|
;;;; enclosing function at all, so there is no qualified name on it to say
|
|
;;;; it belongs to a package. The file it was written in says so instead.
|
|
|
|
(import shadowed "pkgs/shadowed")
|
|
|
|
(defstruct P [x i32])
|
|
|
|
(defn get [p P] i32 (.x p))
|
|
|
|
;;; An operator is a builtin like any other, and shadows like any other: (+ 1
|
|
;;; 2) below is this definition and answers 99. Nothing else in the program
|
|
;;; adds anything, and the prelude's own additions are untouched — the
|
|
;;; prelude is a different file.
|
|
(defn + [a i32 b i32] i32 99)
|
|
|
|
;;; And a builtin the imported package uses in a *global initialiser*, which
|
|
;;; is the one place there is no enclosing function to carry a package's
|
|
;;; qualified name. The package's (defvar size i32 (len "abcd")) is 4; this
|
|
;;; definition answers 999 and is reached only here.
|
|
(defn len [s string] i32 999)
|
|
|
|
(defn main [] ()
|
|
(println (get (P {.x 7})))
|
|
(println (shadowed/field {:a 1 :b 4}))
|
|
(println (+ 1 2))
|
|
(println (len "abcd"))
|
|
(println (shadowed/stored-size)))
|