WIP Refactoring methods: Got it to compile and it mostly works

This commit is contained in:
Joseph Ferano 2023-06-14 22:33:19 +07:00
parent c00500a4e1
commit a3e3fa6551
3 changed files with 48 additions and 10 deletions

View File

@ -60,6 +60,11 @@ pub struct State<'a> {
} }
impl State<'_> { impl State<'_> {
/// Creates a new [`State`].
///
/// # Panics
///
/// Panics if we can't get all the columns from the database
#[must_use] #[must_use]
pub fn new(conn: Connection) -> Self { pub fn new(conn: Connection) -> Self {
let db_conn = db::DBConn::new(conn); let db_conn = db::DBConn::new(conn);
@ -116,6 +121,11 @@ impl State<'_> {
} }
} }
/// Returns the move task up of this [`State`].
///
/// # Panics
///
/// We have conditions to ensure this doesn't panic but we still unwrap()
pub fn move_task_up(&mut self) -> bool { pub fn move_task_up(&mut self) -> bool {
let column = self.get_selected_column_mut(); let column = self.get_selected_column_mut();
if column.selected_task_idx > 0 { if column.selected_task_idx > 0 {
@ -133,6 +143,11 @@ impl State<'_> {
} }
} }
/// Returns the move task down of this [`State`].
///
/// # Panics
///
/// We have conditions to ensure this doesn't panic but we still unwrap()
pub fn move_task_down(&mut self) -> bool { pub fn move_task_down(&mut self) -> bool {
let column = self.get_selected_column_mut(); let column = self.get_selected_column_mut();
if column.selected_task_idx < column.tasks.len().saturating_sub(1) { if column.selected_task_idx < column.tasks.len().saturating_sub(1) {
@ -150,6 +165,11 @@ impl State<'_> {
} }
} }
/// Returns the move task previous column of this [`State`].
///
/// # Panics
///
/// We have conditions to ensure this doesn't panic but we still unwrap()
pub fn move_task_previous_column(&mut self) { pub fn move_task_previous_column(&mut self) {
let first_col = self.get_selected_column_mut(); let first_col = self.get_selected_column_mut();
let task_idx = first_col.selected_task_idx.saturating_sub(1); let task_idx = first_col.selected_task_idx.saturating_sub(1);
@ -163,6 +183,11 @@ impl State<'_> {
self.db_conn.set_selected_column(self.selected_column_idx); self.db_conn.set_selected_column(self.selected_column_idx);
} }
/// Returns the move task previous column of this [`State`].
///
/// # Panics
///
/// We have conditions to ensure this doesn't panic but we still unwrap()
pub fn move_task_next_column(&mut self) { pub fn move_task_next_column(&mut self) {
let first_col = self.get_selected_column_mut(); let first_col = self.get_selected_column_mut();
let task_idx = first_col.selected_task_idx.saturating_sub(1); let task_idx = first_col.selected_task_idx.saturating_sub(1);
@ -176,6 +201,11 @@ impl State<'_> {
self.db_conn.set_selected_column(self.selected_column_idx); self.db_conn.set_selected_column(self.selected_column_idx);
} }
/// Returns the delete task of this [`State`].
///
/// # Panics
///
/// We have conditions to ensure this doesn't panic but we still unwrap()
pub fn delete_task(&mut self) { pub fn delete_task(&mut self) {
let column = self.get_selected_column_mut(); let column = self.get_selected_column_mut();
let task_id = column.get_selected_task().unwrap().id; let task_id = column.get_selected_task().unwrap().id;

View File

@ -65,12 +65,12 @@ impl DBConn {
/// # Panics /// # Panics
/// ///
/// Panics if something goes wrong with the SQL /// Panics if something goes wrong with the SQL
pub fn insert_new_task(&self, title: String, description: String, column: &Column) -> Task { pub fn insert_new_task(&self, title: String, description: String, column_id: i64) -> Task {
let mut stmt = self let mut stmt = self
.0 .0
.prepare("insert into task(title, description, column_id) values (?1, ?2, ?3)") .prepare("insert into task(title, description, column_id) values (?1, ?2, ?3)")
.unwrap(); .unwrap();
stmt.execute(params![title, description, column.id]) stmt.execute(params![title, description, column_id])
.unwrap(); .unwrap();
let id = self.0.last_insert_rowid(); let id = self.0.last_insert_rowid();
Task { Task {

View File

@ -7,7 +7,8 @@ pub fn handle_task_edit(
state: &mut State<'_>, state: &mut State<'_>,
key: event::KeyEvent, key: event::KeyEvent,
) { ) {
if let Some(task) = &mut state.task_edit_state { if let Some(mut task) = state.task_edit_state.take() {
let mut clear_task = false;
match task.focus { match task.focus {
// TODO: Handle wrapping around the enum rather than doing it manually // TODO: Handle wrapping around the enum rather than doing it manually
TaskEditFocus::Title => match key.code { TaskEditFocus::Title => match key.code {
@ -31,19 +32,22 @@ pub fn handle_task_edit(
KeyCode::Enter => { KeyCode::Enter => {
let title = task.title.clone().into_lines().join("\n"); let title = task.title.clone().into_lines().join("\n");
let description = task.description.clone().into_lines().join("\n"); let description = task.description.clone().into_lines().join("\n");
let column = state.get_selected_column_mut();
if task.is_edit { if task.is_edit {
let column = state.get_selected_column_mut();
if let Some(selected_task) = column.get_selected_task_mut() { if let Some(selected_task) = column.get_selected_task_mut() {
selected_task.title = title; selected_task.title = title;
selected_task.description = description; selected_task.description = description;
state.db_conn.update_task_text(selected_task); let cloned = selected_task.clone();
state.db_conn.update_task_text(&cloned);
} }
} else { } else {
let task = state.db_conn.insert_new_task(title, description, column); let col_id = state.get_selected_column().id;
column.add_task(task); let selected_task_idx = state.get_selected_column().selected_task_idx;
state.db_conn.set_selected_task_for_column(column.selected_task_idx, column.id); let task = state.db_conn.insert_new_task(title, description, col_id);
state.get_selected_column_mut().add_task(task);
state.db_conn.set_selected_task_for_column(selected_task_idx, col_id);
} }
state.task_edit_state = None; clear_task = true;
} }
_ => (), _ => (),
}, },
@ -51,11 +55,14 @@ pub fn handle_task_edit(
KeyCode::Tab => task.focus = TaskEditFocus::Title, KeyCode::Tab => task.focus = TaskEditFocus::Title,
KeyCode::BackTab => task.focus = TaskEditFocus::ConfirmBtn, KeyCode::BackTab => task.focus = TaskEditFocus::ConfirmBtn,
KeyCode::Enter => { KeyCode::Enter => {
state.task_edit_state = None; clear_task = true;
} }
_ => (), _ => (),
}, },
} }
if !clear_task {
state.task_edit_state = Some(task);
}
} }
} }
@ -111,6 +118,7 @@ pub fn handle_main(state: &mut State<'_>, key: event::KeyEvent) {
KeyCode::Char('e') => state.task_edit_state = column.get_task_state_from_current(), KeyCode::Char('e') => state.task_edit_state = column.get_task_state_from_current(),
KeyCode::Char('D') => { KeyCode::Char('D') => {
if !column.tasks.is_empty() { if !column.tasks.is_empty() {
state.delete_task();
} }
} }
_ => {} _ => {}